Skip to content

Conversation

@ximinez
Copy link
Owner

@ximinez ximinez commented Mar 18, 2025

  • Get rid of operator<<(std::ostream&, const Value& root), and fix everything that breaks.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

This change is Reviewable

@ximinez ximinez force-pushed the logging branch 3 times, most recently from 4e93b30 to 74506d5 Compare March 25, 2025 16:31
@ximinez ximinez force-pushed the logging branch 3 times, most recently from 9e0269a to e4b20fa Compare April 2, 2025 14:46
@ximinez ximinez force-pushed the logging branch 5 times, most recently from 1052f73 to a584bb7 Compare April 10, 2025 21:42
@ximinez ximinez added NoCI and removed NoCI labels Apr 11, 2025
@ximinez ximinez force-pushed the logging branch 2 times, most recently from 5850230 to 8271319 Compare April 28, 2025 18:46
@ximinez ximinez force-pushed the logging branch 4 times, most recently from 9f9450d to c5f6c24 Compare July 18, 2025 22:37
@ximinez ximinez force-pushed the logging branch 3 times, most recently from 784c748 to 0f11e7d Compare July 24, 2025 22:25
@ximinez ximinez force-pushed the logging branch 4 times, most recently from 77eea1e to 2773ddc Compare August 4, 2025 17:08
@ximinez ximinez force-pushed the logging branch 4 times, most recently from 7770397 to 8b90b54 Compare November 4, 2025 23:32
@ximinez ximinez force-pushed the logging branch 4 times, most recently from e7104f4 to a173f65 Compare November 10, 2025 21:04
* Get rid of operator<<(std::ostream&, const Value& root), and
  fix everything that breaks.
* ximinez/develop:
  ci: Update shared actions (6147)
  chore: Fix some typos in comments (6082)
  refactor: Rename `ripple` namespace to `xrpl` (5982)
  refactor: Move JobQueue and related classes into xrpl.core module (6121)
  refactor: Rename `rippled` binary to `xrpld` (5983)
  refactor: rename info() to header() (6138)
  refactor: rename `LedgerInfo` to `LedgerHeader` (6136)
  refactor: clean up `RPCHelpers` (5684)
  chore: Fix docs readme and cmake (6122)
  chore: Clean up .gitignore and .gitattributes (6001)
  chore: Use updated secp256k1 recipe (6118)
* ximinez/develop:
  ci: Add sanitizers to CI builds (5996)
  test: Use gtest instead of doctest (6216)
  test: Suppress "parse failed" message in Batch tests (6207)
  test: Replace `failed` string in Vault test case (6214)
  Change LendingProtocol feature and dependencies to supported (6146)
  Expand Number to support the full integer range (6025)
  Improve and fix bugs in Lending Protocol (6102)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants