Skip to content

Conversation

@ximinez
Copy link
Owner

@ximinez ximinez commented Mar 18, 2025

  • Instead of a hard cutoff at 5s
  • Network is "unhealthy" if consensus round took more than 5s AND more
    than twice the recent average.<!--
    This PR template helps you to write a good pull request description.
    Please feel free to include additional useful information even beyond what is requested below.

If your branch is on a personal fork and has a name that allows it to
run CI build/test jobs (e.g. "ci/foo"), remember to rename it BEFORE
opening the PR. This avoids unnecessary redundant test runs. Renaming
the branch after opening the PR will close the PR.
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch
-->

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

This change is Reviewable

@ximinez ximinez changed the title Determine TxQ network "health" by average consensus round time DRAFT: Determine TxQ network "health" by average consensus round time Mar 18, 2025
@ximinez ximinez force-pushed the txq-duration branch 3 times, most recently from c7edb89 to 6b6d56a Compare March 25, 2025 16:31
@ximinez ximinez force-pushed the txq-duration branch 3 times, most recently from d9371d4 to ab1a0e8 Compare April 2, 2025 14:46
@ximinez ximinez force-pushed the txq-duration branch 5 times, most recently from bb71aca to e7f47f4 Compare April 10, 2025 21:42
@ximinez ximinez added NoCI and removed NoCI labels Apr 11, 2025
@ximinez ximinez force-pushed the txq-duration branch 2 times, most recently from b1ff6ba to 61cf178 Compare April 28, 2025 18:46
@ximinez ximinez force-pushed the txq-duration branch 4 times, most recently from 196e36f to 49d864c Compare July 18, 2025 22:37
@ximinez ximinez force-pushed the txq-duration branch 3 times, most recently from f2feb0c to bc77a41 Compare July 24, 2025 22:25
@ximinez ximinez force-pushed the txq-duration branch 3 times, most recently from 8b27563 to 8fe92fe Compare July 30, 2025 00:37
@ximinez ximinez force-pushed the txq-duration branch 4 times, most recently from 8b76385 to 377eb27 Compare November 10, 2025 21:04
* Instead of a hard cutoff at 5s
* Network is "unhealthy" if consensus round took more than 5s *AND* more
  than twice the recent average.
* Instead of a hard cutoff at 5s
* Network is "unhealthy" if consensus round took more than 5s *AND* more
  than twice the recent average.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants