forked from XRPLF/rippled
-
Notifications
You must be signed in to change notification settings - Fork 1
DRAFT: Prevent divide by zero in mulDiv: #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ximinez
wants to merge
21
commits into
develop
Choose a base branch
from
overflow2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #11 +/- ##
=======================================
Coverage 78.1% 78.1%
=======================================
Files 790 790
Lines 67913 67916 +3
Branches 8235 8220 -15
=======================================
+ Hits 53032 53046 +14
+ Misses 14881 14870 -11
🚀 New features to boost your workflow:
|
f27001f to
5f1346c
Compare
640ab99 to
4db1658
Compare
d2d2ff9 to
a92defe
Compare
081f6b6 to
cd73dd3
Compare
58f761e to
b67ad45
Compare
37ff755 to
f8afafc
Compare
a385775 to
7bd997e
Compare
5c6c373 to
6554bcd
Compare
ff46b83 to
edbc2ba
Compare
* Every call to mulDiv either uses a literal or constexpr, checks for 0, or throws on overflow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)This change is