Skip to content

Conversation

@ximinez
Copy link
Owner

@ximinez ximinez commented Mar 18, 2025

  • Every call to mulDiv either uses a literal or constexpr, checks for 0, or throws on overflow.

High Level Overview of Change

Context of Change

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

API Impact

  • Public API: New feature (new methods and/or new fields)
  • Public API: Breaking change (in general, breaking changes should only impact the next api_version)
  • libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
  • Peer protocol change (must be backward compatible or bump the peer protocol version)

This change is Reviewable

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.1%. Comparing base (d9b7a26) to head (2aa9f4f).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop     #11   +/-   ##
=======================================
  Coverage     78.1%   78.1%           
=======================================
  Files          790     790           
  Lines        67913   67916    +3     
  Branches      8235    8220   -15     
=======================================
+ Hits         53032   53046   +14     
+ Misses       14881   14870   -11     
Files with missing lines Coverage Δ
src/libxrpl/basics/mulDiv.cpp 100.0% <100.0%> (ø)
src/xrpld/app/misc/detail/TxQ.cpp 98.6% <100.0%> (ø)

... and 11 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ximinez ximinez force-pushed the overflow2 branch 3 times, most recently from f27001f to 5f1346c Compare March 25, 2025 16:31
@ximinez ximinez force-pushed the overflow2 branch 3 times, most recently from 640ab99 to 4db1658 Compare April 2, 2025 14:45
@ximinez ximinez force-pushed the overflow2 branch 6 times, most recently from d2d2ff9 to a92defe Compare April 10, 2025 21:42
@ximinez ximinez added NoCI and removed NoCI labels Apr 11, 2025
@ximinez ximinez force-pushed the overflow2 branch 2 times, most recently from 081f6b6 to cd73dd3 Compare April 28, 2025 18:46
@ximinez ximinez force-pushed the overflow2 branch 2 times, most recently from 58f761e to b67ad45 Compare July 10, 2025 16:38
@ximinez ximinez force-pushed the overflow2 branch 4 times, most recently from 37ff755 to f8afafc Compare July 18, 2025 22:36
@ximinez ximinez force-pushed the overflow2 branch 3 times, most recently from a385775 to 7bd997e Compare July 24, 2025 22:24
@ximinez ximinez force-pushed the overflow2 branch 4 times, most recently from 5c6c373 to 6554bcd Compare November 4, 2025 23:29
@ximinez ximinez force-pushed the overflow2 branch 4 times, most recently from ff46b83 to edbc2ba Compare November 10, 2025 21:02
* Every call to mulDiv either uses a literal or constexpr, checks for 0,
  or throws on overflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants