Fix endpoint configuration for settings #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: undefined
- Change POST to PUT for /api/v1/settings/shift-config endpoint to match REST conventions - Remove /api/v1/settings/bot-config endpoints as bot configuration now uses shift-config - Update swagger.yaml to reflect endpoint changes (PUT instead of POST for shift-config) - Remove bot-config related code from SettingsController Fixes xierongchuan#24 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This reverts commit d6f518d.
Contributor
Author
🤖 Solution Draft LogThis log file contains the complete execution trace of the AI solution draft process. 📎 Log file uploaded as GitHub Gist (321KB) Now working session is ended, feel free to review and add any feedback on the solution draft. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the endpoint configuration issues reported in #24:
Changes Made
Fixed
/api/v1/settings/shift-configendpoint methodPOSTtoPUTto match REST conventions for updating resourcesRemoved
/api/v1/settings/bot-configendpointsGET /api/v1/settings/bot-configroutePOST /api/v1/settings/bot-configroutegetBotConfig()andupdateBotConfig()methods fromSettingsControllerUpdated API documentation
swagger.yamlto reflect the changesshift-configendpoint from POST to PUT in OpenAPI specbot-configendpoint documentationFiles Changed
routes/api.php- Updated endpoint routesapp/Http/Controllers/Api/V1/SettingsController.php- Removed bot-config methodsswagger.yaml- Updated API documentationTesting
The changes ensure that:
PUT /api/v1/settings/shift-configFixes #24
🤖 Generated with Claude Code