CA-411986: Fix heartbeat latency calculation#30
Draft
BengangY wants to merge 1 commit intoxenserver:masterfrom
Draft
CA-411986: Fix heartbeat latency calculation#30BengangY wants to merge 1 commit intoxenserver:masterfrom
BengangY wants to merge 1 commit intoxenserver:masterfrom
Conversation
The `heartbeat_latency` is the interval between each heartbeat transmission. After splitting the heartbeat thread into two threads (sending and receiving), the latency is now measured immediately after sending a heartbeat. With this change, the calculation logic should be updated as follows: 1. If sending the heartbeat takes longer than the configured heartbeat interval, `heartbeat_latency` is the actual elapsed time. 2. Otherwise, `heartbeat_latency` is the configured heartbeat interval. Signed-off-by: Bengang Yuan <bengang.yuan@cloud.com>
psafont
suggested changes
Jun 5, 2025
Contributor
psafont
left a comment
psafont
left a comment
There was a problem hiding this comment.
I'm blocking this because I think the change contravenes the XHA interface specification (which is not public)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
heartbeat_latencyis the interval between each heartbeat transmission. After splitting the heartbeat thread into two threads (sending and receiving), the latency is now measured immediately after sending a heartbeat.With this change, the calculation logic should be updated as follows:
heartbeat_latencyis the actual elapsed time.heartbeat_latencyis the configured heartbeat interval.