This repository was archived by the owner on May 31, 2024. It is now read-only.
Fix isCreditCardExpirationDateValid logic#10
Open
imajindev wants to merge 1 commit intoxendit:masterfrom
Open
Conversation
Author
Author
|
@PatrickBenz09 what you think of this update? |
Author
|
is this library no longer supported? |
zakiarsyad
suggested changes
Mar 24, 2021
| const expYear = Number(cardExpirationYear); | ||
| return ( | ||
| expYear >= currentYear && | ||
| expYear <= 2100 && |
Contributor
There was a problem hiding this comment.
@imajindev could you mind changing into something like this
Suggested change
| expYear <= 2100 && | |
| expYear <= currentYear + 100 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
properly check for the year and month if the credit card expiry number: