Draft
Conversation
Author
|
Oh, the build pipelines definitely also require some adjustments, e.g. build libprojectM beforehand. On Windows/UWP, the add-on could in theory use vcpkg for that, as projectM has a port there. Not sure about how popular vcpkg is with Kodi development though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first, rough update to the add-on to make it work with the latest libprojectM 4.1 release. It runs fine on my Kodi on Linux. The build might need a few additional tweaks, as well as the settings dialog (e.g. adding more options supported by projectM), thus I'm initially creating it as a draft PR.
Note that libprojectM was almost completely rewritten between 4.0 and 4.1, with a new rendering process and expression parser. Due to the internal renderer updates, projectM now requires OpenGL ES 3.2 with the
OES_texture_floatextension being available. For OpenGL Core, at least GL version 3.3 is required (which is the same as before).I don't think the
dependsdir is needed anymore, as libprojectM is now also built with CMake and thus can be found via CMAKE_PREFIX_PATH. This makes it more flexible, as (on Linux) maintainers can choose to use the distro package or compile libprojectM as static libs and directly embed it into the add-on shared library.Also see my comment in the related issue #59 about Windows and Angle.