Fix: Scraper page display bug, SLR scraper fix #2115
+34
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix Scrapers page not showing scrapers on slow devices due to race condition with async store loading. Changed showAllScrapers to local component state with default true instead of persisted store state. - Fix Auto-limit scraping being enabled even when scrape failed (e.g., "Studio code not found" errors). Now only enables after successful scrape. - Fix SLR URL generation producing invalid double-dash URLs. Now uses the `label` field from SLR API directly instead of regenerating URL slugs from titles, preserving legitimate double-dash URLs while avoiding invalid ones. - Disable limit scraping when user selects "Force update scenes" to allow full re-scrape, matching the behavior of "Delete scraped scenes".
mvdeckard
force-pushed
the
fix/scraper-fixes
branch
from
e4b769a to
3f0d67c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
labelfield from API directly instead of regenerating URL slugs from titles, preserving legitimate double-dash URLs while avoiding invalid onescondition with async store loading