Skip to content

Conversation

@samdoidge
Copy link
Contributor

This just makes the card playable via combat, but not added to any strategy

Copy link
Owner

@xaved88 xaved88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! So the reason that we didn't include True Grit a while back was because of the randomness in the un-upgraded version. Unless I'm mistaken (which can totally be the case, I've not done much with this project in over a year), random handling with cards like that wasn't ever accounted for and so this could lead to the bot being very optimistic in its use of the un-upgraded version.

It's probably better to have it in there, but maybe we should add in a comment to note this expected unexpected behaviour?

@samdoidge
Copy link
Contributor Author

Yes, you're completely correct. I ran into the issue you mention when testing (on a new strategy) after creating the PR. I did later code some logic to handle random exhaust. I will see if I can combine some logic in one PR / add the comment as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants