net.Conn for pageant with example and tests #16
Conversation
svanharmelen
left a comment
svanharmelen
left a comment
There was a problem hiding this comment.
I have two initials questions/suggestions... As for testing this myself, I should have access to a Windows machine later this week so I can play with it a little. Thanks so far!
| func New() (agent.Agent, net.Conn, error) { | ||
| if pageantWindow() != 0 { | ||
| return agent.NewClient(&conn{}), nil, nil | ||
| return agent.NewClient(&conn{}), &conn{}, nil |
There was a problem hiding this comment.
What is the point of returning a fake net.Conn here instead of just returning nil to indicate to a user there is no underlying net.Conn connection to be managed/closed?
I think we should omit this and also remove the methods you added for similarity with net.Conn.
I think
| } | ||
|
|
||
| func (c *conn) Close() { | ||
| func (c *conn) Close() error { |
There was a problem hiding this comment.
I assume this is also done to mimic net.Conn? Inline with my other comment I suggest we do not mask this conn type so we can return it as some kind a fake net.Conn.
|
IMHO best: func New() net.Conn{...}
...
conn:=sshagent.New()
if conn==nil{
log.Fatalf(...
}
defer conn.Close()
ag:=agent.NewClient(conn)where conn from:
Maybe conn.Close() not important for &conn{} , but it's important for the rest |
2 participants
Tests and examle works for me.
Congratulations on Programmer's Day!