-
Notifications
You must be signed in to change notification settings - Fork 22
ci: enable test assets and cache them #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1847936 to
942bd3d
Compare
|
Nice! Where is the test asset uploaded? |
|
It’s stored in a short-lived GitHub server somewhere, I guess :)
The caching action uses a caching api provided by GitHub which should be documented somewhere, but I didn’t really investigate. Data gets deleted after being unused for 7 days.
Is it something we should care about?
… Il giorno 6 ago 2025, alle ore 20:55, Weiyi Wang ***@***.***> ha scritto:
wwylele
left a comment
(wwylele/teakra#64)
Nice! Where is the test asset uploaded?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.
|
|
This repo doesn't seem it can maintain activity once a week. So the cache will be deleted? |
|
This repo doesn't seem it can maintain activity once a week. So the
cache will be deleted?
I believe so, yes. And the file will get re-downloaded. Alternatively,
would it make sense to store the file in the repo with git-lfs?
|
|
git-lfs sounds good to me. It is also good for archiving. I don't think I have used my quota at all |
|
I cannot add git-lfs files to the project myself. The way I did so was: |
|
I have uploaded it to https://github.com/wwylele/teakra/tree/master/src/test_verifier/data. I realized this has been downloading from someone else' server in teakra/src/test_verifier/CMakeLists.txt Lines 18 to 25 in a0364b6
|
942bd3d to
b2196ad
Compare
It's required when using multi-config generators like MSVC on Windows
The test file is really big, and downloading it by default may create
issues with users on a slow network.
Use a .lfsconfig file to disable LFS downloads. This way, LFS files can
be explicitly downloaded via
git lfs pull --exclude='' --include='*'
55e9a6f to
58931f2
Compare
|
Hi again! I've reworked with patch set, combining Git LFS with GitHub Actions caching. This way, multiple repeated runs will download the big test asset from the cache instead of LFS storage. The cache is (supposed to be) faster, and LFS bandwidth is limited. I've also disabled Git LFS downloads by default, since most users are unlikely to want to download that test asset, and it takes a long time to do so |
This avoids duplicated runs on merge requests
58931f2 to
09f64b7
Compare
|
Thanks! |
As suggested in #63 (comment)