Skip to content

Fixed PHPDoc and added DateTime support for getEvents and getTODOs function. #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
krrico wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Fixed PHPDoc and added DateTime support for getEvents and getTODOs function. #36

krrico wants to merge 10 commits into from

Conversation

@krrico
Copy link

@krrico krrico commented Apr 9, 2018

This pull request contains the following changes:

  • fixed wrong/missing PHPDoc return types
  • added correct/missing parameter types in PHPDoc
  • added missing throw Exception tags in PHPDoc since only the CalDAVException had beed added
  • fixed some typos in the comments and error strings
  • getEvents and getTODOs can now take DateTime objects instead of only stringified dates that get automatically converted into the correct time zone and time format

Rico Kritz added 5 commits April 9, 2018 14:55
fixed lots of typos, missing parameter types, return types and @throw …
ebef19f 
…tags in SimpleCalDAVClient's PHPDoc which makes it much easier to work with this package in PHP IDEs (like PHPStorm e.g.) and added support for DateTime objects in getEvents and getTODOs (see convertToGmtString in SimpleCalDAVClient)
added another missing PHPDoc parameter type
6200fe8
CalDAVObject has the CalDAVCalendar it was fetched from as property now
0a9d6ba
moved the multiple times used client and calendar checks into separat…
cdf6ab3 
…e functions to increase code readability and reduce redundancy
added getAllEvents and getAllTODOs function that can fetch events and…
b4837a3 
… todos from all available calendars
@krrico
Copy link
Author

krrico commented Apr 10, 2018

Added some more changes:

  • added calendar property to CalDAVObject so each object "knows" what calendar it was fetched from
  • added getAllEvents and getAllTODOs function that can fetch events/TODOs from all available calendars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@krrico