Open
Conversation
Clear file name and input on modal close Add file name and display when selecting a new file Smoothly replace textarea contents with file contents Restrict file extensions to .txt and .json Fixes wustep#37
wustep
reviewed
Aug 17, 2023
| margin: 1rem; | ||
| } | ||
|
|
||
| .file-name { |
Owner
There was a problem hiding this comment.
let's keep the naming convention of BulkImportModal__fileName
wustep
reviewed
Aug 17, 2023
| <label class="label">Import from File</label> | ||
| <div id="BulkImport__file" class="file is-normal"> | ||
| <label class="file-label"> | ||
| <input class="file-input" type="file" accept=".json, .txt" name="resume"> |
Owner
There was a problem hiding this comment.
name probably doesn't do anything here
Owner
There was a problem hiding this comment.
we can add an ID here BulkImportModal__fileInput
wustep
reviewed
Aug 17, 2023
| $('#BulkExportModal').removeClass('is-active'); | ||
| }); | ||
| $('#BulkImportModal__cancel, #BulkImportModal__close').on('click', (e) => { | ||
| $('.file-input').val(''); |
wustep
approved these changes
Aug 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear file name and input on modal close
Add file name and display when selecting a new file
Smoothly replace textarea contents with file contents
Restrict file extensions to .txt and .json
Demo:
bulk-import-file-upload.mp4
Fixes #37