Skip to content
This repository was archived by the owner on Feb 16, 2022. It is now read-only.

Not use react-dom + input tag name#9

Open
hasnat wants to merge 3 commits intowubocong:masterfrom
hasnat:master
Open

Not use react-dom + input tag name#9
hasnat wants to merge 3 commits intowubocong:masterfrom
hasnat:master

Conversation

@hasnat
Copy link
Contributor

@hasnat hasnat commented Jul 18, 2017

I was going to add react-dom to webpack external, but we don't need react-dom its only being used to findNode to set as input, which I have changed to ref as a method for same input.

This brings down dist min file from 230kb to 7kb (not gzipped)

@hasnat
Copy link
Contributor Author

hasnat commented Aug 28, 2017

ping @wubocong

@stevenkissack
Copy link

Would love to see this merged, will use your fork for now. Cheers

@hasnat
Copy link
Contributor Author

hasnat commented Oct 10, 2017

Yea, You can use https://www.npmjs.com/package/@hasnat/react-upload-file for now.

@hasnat
Copy link
Contributor Author

hasnat commented Dec 22, 2017

Added another commit which adds optional prop inputName to help specify file input tag name

@hasnat hasnat changed the title Not use react-dom Not use react-dom + input tag name Dec 22, 2017
@linonetwo
Copy link

@wubocong

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants