-
Notifications
You must be signed in to change notification settings - Fork 28
Add Extendify compatibility class #1007
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request refactors the Extendify compatibility mechanism from a partner ID-based system to an option-based approach. Instead of checking a custom imagify_partner_hide_our_plugins option, the plugin now checks for the existence of Extendify's own extendify_site_id option to determine whether to hide the "Our Plugins" section.
Changes:
- Removed the legacy partner-based hiding system including the
imagify_save_partner_hide_our_pluginsfunction and related calls - Introduced a new
Extendifysubscriber class that hooks into theimagify_hide_plugin_familyfilter - Replaced direct option checking with a filter-based approach using
wpm_apply_filters_typed
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| uninstall.php | Removed cleanup of deprecated imagify_partner_hide_our_plugins option |
| inc/functions/partners.php | Removed the imagify_save_partner_hide_our_plugins function |
| inc/common/partners.php | Removed calls to imagify_save_partner_hide_our_plugins during option updates |
| inc/classes/class-imagify.php | Removed calls to imagify_save_partner_hide_our_plugins during user creation |
| inc/classes/class-imagify-views.php | Changed from direct option check to filter-based approach using wpm_apply_filters_typed |
| classes/ThirdParty/ServiceProvider.php | Registered the new Extendify subscriber class |
| classes/ThirdParty/Hostings/Extendify.php | New subscriber class that checks for extendify_site_id option |
| Tests/Unit/inc/functions/Partners/ImagifySavePartnerHideOurPluginsTest.php | Removed obsolete tests for deleted function |
| Tests/Unit/classes/ThirdParty/Hostings/Extendify/HidePluginFamilyTest.php | Added new test for Extendify subscriber |
| Tests/Fixtures/inc/functions/Partners/ImagifySavePartnerHideOurPluginsTest.php | Removed obsolete test fixtures |
| Tests/Fixtures/classes/ThirdParty/Hostings/Extendify/HidePluginFamilyTest.php | Added new test fixtures for Extendify subscriber |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tests/Unit/classes/ThirdParty/Hostings/Extendify/HidePluginFamilyTest.php
Show resolved
Hide resolved
Tests/Fixtures/classes/ThirdParty/Hostings/Extendify/HidePluginFamilyTest.php
Show resolved
Hide resolved
Tests/Unit/classes/ThirdParty/Hostings/Extendify/HidePluginFamilyTest.php
Show resolved
Hide resolved
|
@remyperona Thanks for the PR. Here is exploratory test notes
|
nicomollet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving
For @Mai-Saad
- Any value in
extendify_site_idwould hide the plugin family, it is expected. - The error in screenshot
ERR_QUIC_PROTOCOLdoesn't seem related to Imagify: can you retry again?
@nicomollet yes working fine now 🙏 |

Description
Modify the compatibility with Extendify to use an option instead of the partner ID
Type of change
Detailed scenario
What was tested
Tested the display of the
Our Pluginssection, based on the existance of the optionextendify_site_idHow to test
You can simulate the option using:
Affected Features & Quality Assurance Scope
Imagify settings page, our plugins section
Technical description
Documentation
This pull request refactors the Extendify compatibility mechanism from a partner ID-based system to an option-based approach. Instead of checking a custom
imagify_partner_hide_our_pluginsoption, the plugin now checks for the existence of Extendify's ownextendify_site_idoption to determine whether to hide the "Our Plugins" section.Changes:
imagify_save_partner_hide_our_pluginsfunction and related callsExtendifysubscriber class that hooks into theimagify_hide_plugin_familyfilterwpm_apply_filters_typedMandatory Checklist
Code validation
Code style