Paladin: Refactor stopattack UI options + add manually triggered attacks as an experimental feature for prot#1110
Open
wsphillips wants to merge 18 commits intowowsims:masterfrom
Open
Paladin: Refactor stopattack UI options + add manually triggered attacks as an experimental feature for prot#1110wsphillips wants to merge 18 commits intowowsims:masterfrom
wsphillips wants to merge 18 commits intowowsims:masterfrom
Conversation
wsphillips
commented
Sep 30, 2024
Comment on lines
-34
to
-38
| righteousFury: protOptions.RighteousFury, | ||
| IsUsingDivineStormStopAttack: protOptions.IsUsingDivineStormStopAttack, | ||
| IsUsingJudgementStopAttack: protOptions.IsUsingJudgementStopAttack, | ||
| IsUsingCrusaderStrikeStopAttack: protOptions.IsUsingCrusaderStrikeStopAttack, | ||
| personalBlessing: protOptions.PersonalBlessing, |
Contributor
Author
There was a problem hiding this comment.
We don't need to duplicate these spec options into the Protection/Retribution structs. They're all already in the regular Options field of the paladin struct. I left primarySeal just in case, but removed the affected fields here and in the RetributionPaladin struct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protection paladins can force extra attacks gained via Reckoning to be stored until the next melee swing by manually triggering each melee swing when the swing timer is ready. By using a stopattack/@target macro on rotational abilities, we can also store WS/HoJ/etc procs gained between melee swings.
This PR adds an experimental option to simulate doing the above with perfect accuracy/timing. While possible in game (confirmed on PTR), this is difficult to do in practice and DPS gains in simulations with this feature enabled are informative but potentially misleading. Simply put: it's unlikely that even the sweatiest of prot paladins will be able to do it perfectly throughout an entire encounter, and missing the timings can have detrimental effects on DPS. As such, I have put it behind the
Show Experimentaloption and added a simulator warning that turns on when the feature is enabled.Nonetheless, simulating manually triggered autoattacks with slow 1H weapons yields a ~10-20% DPS increase, so I think it's worth having the option for advanced users to see the potential gains in an idealized setting.
This PR also includes some refactoring of how stopattack macros get saved and processed in the paladin spec options. It uses a bit mask + bit-shifted spell codes to make the code simpler for both protection and retribution paladins.