Skip to content

Add query parameter locale to Wowhead Tooltip url #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
htve wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add query parameter locale to Wowhead Tooltip url #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e642ca8
Add query parameter locale to Wowhead Tooltip url
htve Jan 6, 2026
cf31c79
Migrate WoWHead language Id map to wowhead_locale_service.ts
htve Jan 6, 2026
57275f6
Refactor the function to get wowhead lang id
htve Jan 6, 2026
9136760
Migrate wowhead_locale_service.ts to wowhead.ts
htve Jan 6, 2026
ec2f67e
Remove the dependencies in the Locale Service in the database
htve Jan 7, 2026
27f63b1
Remove unused import from wowhead
htve Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ui/core/proto_utils/database.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import { Consumable, ItemEffectRandPropPoints, SimDatabase } from '../proto/db';
import { SpellEffect } from '../proto/spell';
import { GlyphID, IconData, UIDatabase, UIEnchant as Enchant, UIGem as Gem, UIItem as Item, UINPC as Npc, UIZone as Zone } from '../proto/ui.js';
import { distinct } from '../utils.js';
import { WOWHEAD_EXPANSION_ENV } from '../wowhead';
import { WOWHEAD_EXPANSION_ENV, getWowheadLanguageId } from '../wowhead';
import { EquippedItem } from './equipped_item.js';
import { Gear, ItemSwapGear } from './gear.js';
import { gemEligibleForSocket, gemMatchesSocket } from './gems.js';
Expand Down Expand Up @@ -400,7 +400,7 @@ export class Database {
return Database.getWowheadTooltipData(id, 'spell', { signal: options?.signal });
}
private static async getWowheadTooltipData(id: number, tooltipPostfix: string, options: { signal?: AbortSignal } = {}): Promise<IconData> {
const url = `https://nether.wowhead.com/mop-classic/tooltip/${tooltipPostfix}/${id}?lvl=${CHARACTER_LEVEL}&dataEnv=${WOWHEAD_EXPANSION_ENV}`;
const url = `https://nether.wowhead.com/mop-classic/tooltip/${tooltipPostfix}/${id}?lvl=${CHARACTER_LEVEL}&dataEnv=${WOWHEAD_EXPANSION_ENV}&locale=${getWowheadLanguageId()}`;
try {
const response = await fetch(url, { signal: options?.signal });
const json = await response.json();
Expand Down
22 changes: 22 additions & 0 deletions ui/core/wowhead.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@ import { getLang } from '../i18n/locale_service';
import { CHARACTER_LEVEL } from './constants/mechanics';
import { Database } from './proto_utils/database';

const DEFAULT_LANG_ID = 0;

//refer to Wowhead locale Ids
const LANG_ID_MAP: Record<string, number> = {
ko: 1,
fr: 2,
de: 3,
cn: 4,
es: 6,
ru: 7,
pt: 8,
it: 9,
tw: 10,
mx: 11,
} as const;

export type WowheadTooltipItemParams = {
/**
* @description Item ID
Expand Down Expand Up @@ -142,3 +158,9 @@ export function getWowheadLanguagePrefix(): string {
const lang = getLang();
return lang === 'en' ? '' : `${lang}/`;
}

// Map language code to numeric Id
export const getWowheadLanguageId = (lang: string = getLang()): number => {
const normalized = lang.toLowerCase();
return LANG_ID_MAP[normalized] ?? DEFAULT_LANG_ID;
};