Add reforge optimizer setting for Hit/Expertise preference#1222
Add reforge optimizer setting for Hit/Expertise preference#1222Saji-Saji wants to merge 2 commits intowowsims:masterfrom
Conversation
… of to expertise when both options are present. Enable this by default for all mage specs
|
Can we not bake this into the reforger itself instead of making it a boolean? Just checking for all caster specs (but then in JS) |
- Removed preferHitOverExpertise boolean parameter from ReforgeOptimizer - Replaced with automatic caster spec detection - Casters (Mage, Warlock, Priest, Balance/Resto Druid, Ele/Resto Shaman, Holy Paladin, Mistweaver Monk) now automatically prefer Hit over Expertise - Removed preferHitOverExpertise: true from all mage spec UIs
f3100e8 to
ceb6b53
Compare
Baked in for all caster specs, Hesitant if we should do this for Holy Paladin or Mistweaver, as they may want to actually use expertise at times? We don't exactly support it, but someone may be using it. |
Yea I think you can leave those out indeed. As they can also proc RoRo since they are considered Melee. (need to change that still) |
This pull request introduces a new option to the
ReforgeOptimizerthat allows caster classes to prefer Hit Rating over Expertise Rating when suggesting reforges. This helps ensure that, when both stats are available as reforging options, Hit is prioritized, which is more relevant for caster classes. The option is enabled by default for all Mage specializations. Additionally, this seems to make reforging decisions faster when enabled for casters as it removes possible options.Key changes:
Reforge logic improvements:
preferHitOverExpertiseoption toReforgeOptimizerOptionsand implemented logic inReforgeOptimizerto filter out Expertise reforges in favor of Hit reforges for items that don't natively have either stat. [1] [2] [3] [4]Mage specialization updates:
preferHitOverExpertiseoption by default for Arcane, Fire, and Frost Mage simulation UIs to improve reforge suggestions for caster gear. [1] [2] [3]