Issue-1201 : Notify slack for the new issue/bounties #1338

devmaster-x · 2026-01-12T04:03:47Z

Related Issues

close #1201

What is updated

Notify about new issues/bounties to the slack channel using webhook.

Screentshot

Test

…resolve signup page issue

alexanmtz

It's doing great @devmaster-x 👌

Tested posting to the channel, and it's working well 🙏

Just need some small adjustment for the case of the issue imported is set to not_listed

I would recommend to add to the tasks tests a spy which checks if the Slack method is called, and it's not called in case for tasks with not_listed set.

alexanmtz · 2026-01-13T21:39:34Z

src/modules/tasks/taskBuilds.js

+            if (userData.receiveNotifications) {
+              TaskMail.new(userData, taskData)
            }
+            issueAddedComment(task)


We should check here before calling issueAddedComment whether the issue is not_listed or private; in that case, it shouldn't be added to the channel.

@alexanmtz

Updated code to check not_listed and private issues before calling issueAddedComment().

const isTaskPublic = !(taskData.not_listed === true || taskData.private === true) if (isTaskPublic) { issueAddedComment(task) notifyNewIssue(taskData, userData) }

alexanmtz · 2026-01-13T21:41:10Z

src/modules/orders/orderBuilds.js

  const percentage = orderCreated.Plan?.feePercentage

+  // Notify Slack about new bounty
+  if (orderCreated.Task && orderCreated.User) {


Don't post on the channel if the related task is set to not_listed or private

@alexanmtz

Updated code to check not_listed and private issues before notify about new bounty.

const shouldNotifySlack = orderCreated.Task && orderCreated.User && !( orderCreated.Task.dataValues.not_listed === true || orderCreated.Task.dataValues.private === true ) if (shouldNotifySlack) { notifyNewBounty( orderCreated.Task.dataValues, orderCreated.dataValues, orderCreated.User.dataValues ) }

alexanmtz

Hey @devmaster-x, some more improvements are needed to have everything in place to merge.

alexanmtz · 2026-01-15T13:00:51Z

src/modules/orders/orderUpdateAfterStripe.js

+      .then(async (updatedOrder) => {
        if (orderParameters.plan === 'full') {
          PaymentMail.support(user, task, order)
        }
        PaymentMail.success(user, task, order.amount)
+
+        // Send Slack notification for new bounty payment
+        if (orderPayload.paid && orderPayload.status === 'succeeded') {
+          const orderData = {
+            amount: order.amount || orderParameters.amount,
+            currency: order.currency || orderParameters.currency || 'USD'
+          }
+          notifyNewBounty(task.dataValues, orderData, user).catch((e) => {
+            console.log('error on send slack notification for new bounty', e)
+          })
+        }
+


@devmaster-x because you introduced async it should be something like this?

Suggested change

.then(async (updatedOrder) => {

if (orderParameters.plan === 'full') {

PaymentMail.support(user, task, order)

}

PaymentMail.success(user, task, order.amount)

// Send Slack notification for new bounty payment

if (orderPayload.paid && orderPayload.status === 'succeeded') {

const orderData = {

amount: order.amount || orderParameters.amount,

currency: order.currency || orderParameters.currency || 'USD'

}

notifyNewBounty(task.dataValues, orderData, user).catch((e) => {

console.log('error on send slack notification for new bounty', e)

})

}

.then(async (updatedOrder) => {

if (orderParameters.plan === 'full') {

PaymentMail.support(user, task, order)

}

PaymentMail.success(user, task, order.amount)

// Send Slack notification for new bounty payment

if (orderPayload.paid && orderPayload.status === 'succeeded') {

const orderData = {

amount: order.amount || orderParameters.amount,

currency: order.currency || orderParameters.currency || 'USD'

}

try {

await notifyNewBounty(task.dataValues, orderData, user)

} catch (e) {

console.log('error on send slack notification for new bounty', e)

}

}

alexanmtz · 2026-01-15T13:14:04Z

test/task.test.js

+    it('should not call Slack methods when task is created with not_listed set to true', async () => {
+      chai.use(spies)
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/999',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task',
+          not_listed: true
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.not.have.been.called()
+        expect(botSpy).to.not.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+      }
+    })
+
+    it('should not call Slack methods when task is created with private set to true', async () => {
+      chai.use(spies)
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/998',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task',
+          private: true
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.not.have.been.called()
+        expect(botSpy).to.not.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+      }
+    })
+
+    it('should call Slack methods when task is created as public', async () => {
+      chai.use(spies)
+
+      // Set up spies first
+      const slackModule = require('../src/modules/slack')
+      const slackSpy = chai.spy.on(slackModule, 'notifyNewIssue')
+
+      // For default export function, create a spy wrapper
+      delete require.cache[require.resolve('../src/modules/bot/issueAddedComment')]
+      const originalBotModule = require('../src/modules/bot/issueAddedComment')
+      const botSpy = chai.spy(originalBotModule)
+
+      try {
+        const user = await registerAndLogin(agent)
+        // Create task without explicitly setting not_listed/private (should default to false)
+        const task = await models.Task.create({
+          url: 'https://github.com/worknenjoy/gitpay/issues/997',
+          provider: 'github',
+          userId: user.body.id,
+          title: 'Test Task'
+        })
+
+        const userData = await task.getUser()
+        const taskData = task.dataValues
+
+        // Test the actual logic from taskBuilds.js
+        const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+        if (isTaskPublic) {
+          // Use the spied version
+          botSpy(task)
+          slackModule.notifyNewIssue(taskData, userData)
+        }
+
+        expect(slackSpy).to.have.been.called()
+        expect(botSpy).to.have.been.called()
+      } finally {
+        chai.spy.restore(slackModule, 'notifyNewIssue')
+        // Restore cache
+        delete require.cache[require.resolve('../src/modules/slack')]
+        delete require.cache[require.resolve('../src/modules/bot/issueAddedComment')]
+      }
+    })
+


I guess here is not the right approach to test the integration. This should be more like an API testing, check other tests in the file, like calling the agent to the endpoint to create a new task and check if the Slack is called, and instead of these spies, there's a good example of an approach using Stubs on userAuth.test:242, so you can check if your integration is called and the expected params

alexanmtz · 2026-01-16T12:31:49Z

test/task.test.js

+const { notifyNewIssue } = require('../src/modules/slack')
+const issueAddedComment = require('../src/modules/bot/issueAddedComment')


I guess this is not used here, right? As you moved to another test file.

Let me check.

@alexanmtz

Yes, you are right, I removed unused imports.

alexanmtz · 2026-01-16T13:33:40Z

src/modules/orders/orderBuilds.js

+  // Skip Slack notifications for private or not_listed tasks
+  const shouldNotifySlack =
+    orderCreated.Task &&
+    orderCreated.User &&
+    !(
+      orderCreated.Task.dataValues.not_listed === true ||
+      orderCreated.Task.dataValues.private === true
+    )
+
+  if (shouldNotifySlack) {
+    notifyNewBounty(
+      orderCreated.Task.dataValues,
+      orderCreated.dataValues,
+      orderCreated.User.dataValues
+    )
+  }
+


Let's remove it from here, because for cases of invoice payments they will not be deducted until is paid, so you can leave it for now only on orderUpdateAfterStripe

alexanmtz · 2026-01-16T16:10:47Z

src/modules/orders/orderBuilds.js

+    // Send Slack notification for wallet payment (paid immediately)
+    const shouldNotifySlack =
+      orderCreated.Task &&
+      orderCreated.User &&
+      !(
+        orderCreated.Task.dataValues.not_listed === true ||
+        orderCreated.Task.dataValues.private === true
+      )
+
+    if (shouldNotifySlack) {
+      try {
+        const orderData = {
+          amount: orderCreated.dataValues.amount,
+          currency: orderCreated.dataValues.currency || 'USD'
+        }
+        await notifyNewBounty(orderCreated.Task.dataValues, orderData, orderCreated.User.dataValues)
+      } catch (e) {
+        console.log('error on send slack notification for new bounty', e)
+      }
+    }
+


This logic should be moved to line 241, which handles a successful Wallet payment. And there, you don't need to get the order details because they're defined later.

alexanmtz

Thanks @devmaster-x , testing the functionality it's working in all cases.

It was a good refactoring to create a full module for Slack integration.

We just need to fine tunning your latest changes as requested here, plus we need to address this before we can merge:

There's too many comments, you can see the application don't have in general this guideline to comment all, the code and tests should speak for itself
We need to move the whole module to './shared', because this is a shared module and not an specific entity
We need to only have in this PR the changes related to this PR. i can see you did a lot of improvements, and we can have it in another PR, so we can test without break anything.

for the last item, you can do this:

To not loose this changes and use for another PR, you can run git branch refactor/fixes-on-user-role-and-payments to create a new branch and keep safe all your changes to create another PR later on
Run this command to no related files that has refactoring not related to this issue (the ones related on user roles, payment components and migration files):
git checkout master -- /path/of/file
Commit the changes and push

When we have this PR merged you can get back to the first branch, and getting the changes for master the only changes in the new PR will be the one left no related to this issue.

I hope is clear and you can always reach out to us on Slack ;)

alexanmtz · 2026-01-20T20:14:11Z

src/modules/orders/orderBuilds.js

+        currency: orderCreated.dataValues.currency || 'USD'
+      }
+      // Avoid even invoking notification helper for private/not_listed tasks
+      if (slack.shouldNotifyForTask(orderWithAssociations.Task)) {


If the method notifyBountyWithErrorHandling already have an internal check for shouldNotifyForTask, I believe this condition can be removed, no?

alexanmtz · 2026-01-20T20:18:59Z

src/modules/slack/index.ts

+ * @param context - Optional context string for error logging (e.g., 'wallet payment', 'PayPal payment')
+ * @returns Promise<boolean> - True if notification was sent successfully
+ */
+export const notifyBountyWithErrorHandling = async (


Honestly, the notifyBountyWithErrorHandling is not a good name, but I couldn't think in one better 😆

The problem is that the main function called notifyBounty should be the main one and the one which is now notifyBounty should have a more longer, like notifyBountyOnSlack

alexanmtz · 2026-01-20T20:25:29Z

src/modules/tasks/taskBuilds.js

+            // Skip Slack notifications for private or not_listed tasks
+            const isTaskPublic = !(taskData.not_listed === true || taskData.private === true)
+            if (isTaskPublic) {
              issueAddedComment(task)
-            } catch (e) {
-              console.log('error on send email and post', e)
+              slack.notifyNewIssue(taskData, userData)


You already have the method shouldNotifyForTask that should be used on notifyNewIssue.

So don't need this check here, but inside shouldNotifyForTask method. asyou did for the check for bounty.

And the issueAddedComment should not be part of this check, so there's no problem moving the logic inside the method notifyNewIssue to check whether we should notify a new issue.

devmaster-x added 4 commits January 8, 2026 19:03

Chore : add cross-env to npm commands, error handling on db connect, …

1ca04de

…resolve signup page issue

implement slack notification feature

1de29dd

Fix lint and update slack notication message content

47c7caf

fix lint

cfc2cbe

dosubot bot added the slack trigger to slack channel label Jan 12, 2026

devmaster-x added 2 commits January 12, 2026 13:05

Update slack notification test

cba69fb

Fix build error

5b33e15

alexanmtz requested changes Jan 13, 2026

View reviewed changes

devmaster-x added 2 commits January 14, 2026 22:55

update handling for not_listed, private issues in slack notification

e1147f7

fix build CI errors

4b1448e

devmaster-x force-pushed the feat/post-slack-notifications branch from e1d86a3 to 4b1448e Compare January 14, 2026 16:21

devmaster-x requested a review from alexanmtz January 14, 2026 16:45

alexanmtz requested changes Jan 15, 2026

View reviewed changes

devmaster-x added 2 commits January 16, 2026 00:21

Add error handling and update test

aba1802

update test

7ca142f

alexanmtz requested changes Jan 16, 2026

View reviewed changes

remove unused import.

06af7be

alexanmtz requested changes Jan 16, 2026

View reviewed changes

Chore : update slack notification for new paid complete bounties

822b608

alexanmtz requested changes Jan 16, 2026

View reviewed changes

devmaster-x added 3 commits January 17, 2026 05:30

fix props error

5af29c3

fix lint error

1bc2ac7

Fix slack notification and stabilize tests

f827481

devmaster-x requested a review from alexanmtz January 20, 2026 04:52

alexanmtz requested changes Jan 20, 2026

View reviewed changes

		const { notifyNewIssue } = require('../src/modules/slack')
		const issueAddedComment = require('../src/modules/bot/issueAddedComment')

Uh oh!

Issue-1201 : Notify slack for the new issue/bounties #1338

Are you sure you want to change the base?

Issue-1201 : Notify slack for the new issue/bounties #1338

Uh oh!

Conversation

devmaster-x commented Jan 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

What is updated

Screentshot

Test

Uh oh!

alexanmtz left a comment

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexanmtz Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexanmtz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexanmtz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devmaster-x commented Jan 12, 2026 •

edited

Loading

alexanmtz Jan 13, 2026 •

edited

Loading

alexanmtz Jan 13, 2026 •

edited

Loading