Open
Conversation
Member
Collaborator
Author
|
@PetrosPapapa It would in the long term. I did this by hand, as I had to read the code to understand it anyway. I can add the configuration for that tool as part of this PR, so that it is available for use in the future. |
Collaborator
Author
|
I tried to configure scalafmt as best as I could. One issue I still have with the current configuration is with how it multilines long argument lists. For example: is formatted as which, in my opinion, is not an improvement. However, I don't know if there is a configuration option for this case, so we might have to live with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I am going through the code, I will do my best to clean it up and make it more readable. This includes adding documentation and comments where useful, renaming variables to reflect content, replacing tabs with spaces, indenting, ...