Closed
Conversation
On my machine:
- ◭ ("Up-pointing triangle with left half black")
- ◮ ("Up-pointing triangle with right half black")
look pretty bad in the terminal, so swap them for something else.
Trying to distinguish from "normal" lines a little more explicitly.
Contributor
Author
|
Draft for now for reasons indicated. Let me know what you think, @wolffiex. |
wincent
added a commit
to wincent/wincent
that referenced
this pull request
Jul 19, 2024
Upstream has made a number of changes, merging in some PRs that I sent and adding some equivalent functionality. So I rebased the remaining branches that matter and added some necessary things on top. Overall, I currently have these PRs open: - wolffiex/shellbot#7 ("docs: fix formatting in README"); this is a redo of: wolffiex/shellbot#1 - wolffiex/shellbot#8 ("chore: remove debugging println!"); necessary because upstream added a new file-based prompt customization mechanism, but you can't use it without removing the debugging statements. - wolffiex/shellbot#9 ("feat: refactor health check to allow spaces in SHELLBOT"); necessary to keep healthcheck working if you take advantage of the new file-based prompt customization. - wolffiex/shellbot#10 ("feat: cosmetic tweaks for Neovim"); draft because it would require some changes to directory layout to make it complete, and I don't know if upstream will be open to that. I updated the `wincent` branch in my fork to contain all of these, all on top of latest upstream `main`. Note that upstream did some renaming ("ChatGPT" → "ChatBot") so I mirrored that here too. * aspects/nvim/files/.config/nvim/pack/bundle/opt/shellbot/lua cc3a399...bef7bb5 (40): > Merge branch 'cosmetic-tweaks' into wincent > Merge branch 'fix-healthcheck' into wincent > Merge branch 'remove-debug-statements' into wincent > Merge branch 'readme-formatting' into wincent > Chatbot rename > Transcript error > Logging and fixes newlines > Add file arg for system prompt > Write one line instead of two > Print non-sse output to stderr > Generate buffer titles > Improve error handling > Try merge again > README update > New Anthropic model! > Merge pull request #2 from wincent/assistant-typo > Merge pull request #4 from wincent/ft > Merge pull request #5 from wincent/healthcheck > Prompt cleanup > Rename > Remove ProviderType > Simplify > Remove some async > Cleanup > Oops > README update > cleanup > Remove test transcript > Both work > Builds with anthropic client > Refactor sse converter > Separate api provider into module > Merge pull request #6 from wincent/header-after-interrupt < Merge branch 'header-after-interrupt' into wincent < Merge branch 'cosmetic-tweaks' into wincent < Merge branch 'healthcheck' into wincent < Merge branch 'ft' into wincent < Merge branch 'custom-prompt' into wincent < Merge branch 'assistant-typo' into wincent < Merge branch 'readme-formatting' into wincent
Owner
|
This is awesome! Thanks for the contribution! |
wincent
added a commit
to wincent/shellbot
that referenced
this pull request
Oct 11, 2024
As noted in: - wolffiex#10 This allows the repo to be installed directly as a Neovim plugin without having to copy files around, and opens the door to us shipping a syntax file, which I'll do in the next commit.
Contributor
Author
|
Superseded by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft for now because it would require bigger changes to directory layout in order to fully complete it. If you want me to make those changes, let me know and I can update.
Before this PR
After this PR
With a syntax file
That last screenshot shows what the non-breaking spaces are all about: they provide us with something we can conveniently syntax-highlight to make the headers stand out:
So, why can't I include the syntax file in this PR? Because syntax files have to live under a
syntaxdirectory, but the repo doesn't have the right layout right now; ie. the current layout is:but the final layout would need to be something like:
ie.
luasubdirectory; this is where Neovim expects to find Lua files such that they can be imported withrequire('shellbot').syntax/shellbot.lua; standard location for syntax files, automatically loaded whenshellbot'filetype'is activated.