compatibility feature flags: private ips in default vrf & loopback interface type

cosmo/clients/netbox_v4.py

@@ -126,8 +126,7 @@ def _fetch_data(self, kwargs, pool):
             """
             query{
               interface_list(filters: {
-                name: {starts_with: "lo"},
-                type: {exact:"loopback"}
+                name: {starts_with: "lo"}
               }) {
                 __typename
                 name,

cosmo/features.py

@@ -97,5 +97,10 @@ def exe_with_feature(*args, **kwargs):
 
 
 features = FeatureToggle(
-    {"interface-auto-descriptions": True, "new-bgp-cpe-group-naming": False}
+    {
+        "interface-auto-descriptions": True,
+        "new-bgp-cpe-group-naming": False,
+        "allow-private-ips-default-vrf": False,
+        "netbox-loopback-interface-type": False,
+    }
 )

cosmo/netbox_types.py

@@ -17,6 +17,7 @@
     head,
     CosmoOutputType,
 )
+from .features import features
 from typing import (
     Self,
     Iterator,
@@ -675,11 +676,15 @@ def isLoopbackOrParentIsLoopback(self) -> bool:
                 )
             return parent_interface.isLoopbackOrParentIsLoopback()
         elif self.getName().startswith("lo"):
-            raise InterfaceSerializationError(
-                f"Interface {self.getName()} is named as a loopback but is not marked"
-                f"as such in the data source, please fix.",
-                on=self,
-            )
+            if self.getAssociatedType() != "loopback" and features.featureIsEnabled(
+                "netbox-loopback-interface-type"
+            ):
+                raise InterfaceSerializationError(
+                    f"Interface {self.getName()} is named as a loopback but is not marked"
+                    f"as such in the data source, please fix.",
+                    on=self,
+                )
+            return True
         return False
 
     def getIPAddresses(self) -> list[IPAddressType]:

cosmo/routervisitor.py

@@ -19,6 +19,7 @@
 from cosmo.vrfhelper import TVRFHelpers
 from cosmo.manufacturers import ManufacturerFactoryFromDevice
 from cosmo.routerbgpcpevisitor import RouterBgpCpeExporterVisitor
+from cosmo.features import features
 from cosmo.routerl2vpnvisitor import (
     RouterL2VPNValidatorVisitor,
     RouterL2VPNExporterVisitor,
@@ -54,7 +55,9 @@ def __init__(
         self.l2vpn_validator = RouterL2VPNValidatorVisitor(loopbacks=loopbacks, asn=asn)
         self.bgpcpe_exporter = RouterBgpCpeExporterVisitor()
         self.loopbacks = loopbacks
-        self.allow_private_ips = False
+        self.allow_private_ips = features.featureIsEnabled(
+            "allow-private-ips-default-vrf"
+        )
         self.asn = asn
 
     def getASN(self) -> int:

cosmo/tests/utils.py

@@ -76,7 +76,7 @@ def patchPostFunc(url, json, **kwargs):
                     retVal["interface_list"] = patchKwArgs.get(
                         "connected_devices_interface_list", []
                     )
-                elif "loopback" in q:
+                elif 'starts_with: "lo"' in q:
                     retVal["interface_list"] = patchKwArgs.get(
                         "loopback_interface_list", []
                     )