Made React a peer dependency. (Fixes Issue #11)#24
Open
joshhales1 wants to merge 2 commits intowko27:masterfrom
Open
Made React a peer dependency. (Fixes Issue #11)#24joshhales1 wants to merge 2 commits intowko27:masterfrom
joshhales1 wants to merge 2 commits intowko27:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second installation of React created by this package causes this error to be thrown and break the application:
This is discussed in #11 as is fixed in this PR.
Having React as a peer dependency fixes this issue. This follows the format of other React packages having React as a peer dependency.
This also massively reduces the installation time of the package.