feat: read bind password from file, not cleartext from config#69
Closed
seanschneeweiss wants to merge 1 commit intowiltonsr:mainfrom
Closed
feat: read bind password from file, not cleartext from config#69seanschneeweiss wants to merge 1 commit intowiltonsr:mainfrom
seanschneeweiss wants to merge 1 commit intowiltonsr:mainfrom
Conversation
Author
|
Sorry, I wanted to create this PR in the fork. We might create a proper PR after we tested this successfully. |
Owner
|
Hello, @seanschneeweiss Thanks for your interest in Please check #13 and #47 where there is an ongoing conversation about this feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of providing the bind password cleartext in the middleware configuration, this PR reads the password from disk.
The filepath is provided by
bindPasswordfield, this can be a mounted secret.