-
Notifications
You must be signed in to change notification settings - Fork 1
Show next alert time in notification #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Show next alert time in notification #90
Conversation
|
Does this look like the right approach? |
|
Just wanted to say thanks for the PR! I'll wait to fully review until your marked ready for review. But could you add a screenshot and some tests for the message generation? |
android/app/src/main/java/com/github/quarck/calnotify/textutils/EventFormatter.kt
Outdated
Show resolved
Hide resolved
|
Thanks for your response! I'm attempting to build the app so I can finish this PR - what am I doing wrong to get this? |
7482846 to
968bba6
Compare
|
Couldn't get a build working locally but I believe I have the code in a reasonable state - let's see if it passes CI! |
This issue looks like you are missing some of the packages in node modules. But we need to see more of the stacktrace to be sure So that is making sure to yarn install or whatever the equivalent is for which package manager you like to use. |
|
Thanks for the pointers - i've The build stack trace, with debug on is here(if there's a simpler way without Android Studio, I'm all ears) |
4541667 to
b4eab3f
Compare
|
also heads up I rebased your branch on master so you'll need to either a. delete your local and pull the rebase version on github now b. or rebase your local on the latest master and force push to this branch again |
Thanks - I've ditched I'll iterate with GH actions for a bit and see if I can get something together. |
b4eab3f to
6427533
Compare
|
@bobrippling fixed it up a bit in #132 |
|
Oh nice - I can help give it a test, thanks very much |


This shows the next alert time (if setting enabled, and if there is a next alert time), in the notification
Closes #89
Todo:
EventRecordtoEventFormatter.formatNotificationSecondaryText()