feat!: room integration p1 MonitorStorage #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
android/app/src/main/java/com/github/quarck/calnotify/monitorstorage/MonitorDatabase.kt
Show resolved
Hide resolved
Code Coverage Report
Files
|
📊 Code Coverage Summary
|
1 similar comment
📊 Code Coverage Summary
|
williscool
force-pushed
the
feat/room_migration_p1
branch
from
dd6ccbf to
5ea9eb0
Compare
📊 Code Coverage Summary
|
williscool
changed the title
📊 Code Coverage Summary
|
williscool
commented
Dec 30, 2025
android/app/src/main/java/com/github/quarck/calnotify/monitorstorage/MonitorDatabase.kt
Outdated
Show resolved
Hide resolved
williscool
commented
Dec 30, 2025
android/app/src/main/java/com/github/quarck/calnotify/monitorstorage/MonitorStorage.kt
Show resolved
Hide resolved
android/app/src/main/java/com/github/quarck/calnotify/monitorstorage/RoomMonitorStorage.kt
Show resolved
Hide resolved
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
2 similar comments
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
| fun delete(entity: MonitorAlertEntity) | ||
|
|
||
| @Delete | ||
| fun deleteAll(entities: List<MonitorAlertEntity>) |
There was a problem hiding this comment.
Batch operations lack transactional atomicity guarantees
The legacy implementation wraps batch operations (addAlerts, deleteAlerts, updateAlerts, deleteAlertsMatching) in explicit database transactions, providing all-or-nothing atomicity. The Room DAO methods insertAll, updateAll, and deleteAll lack @Transaction annotations, meaning each item is processed in a separate implicit transaction. If the app crashes mid-batch or an error occurs, some items may be committed while others aren't, causing data inconsistency. This differs from the legacy behavior which would rollback the entire batch on failure.
Additional Locations (1)
…vity UI tests These tests were taking 15-60+ seconds each due to: - Ultron polling for 15 seconds when views weren't immediately ready - Battery optimization dialog blocking view assertions - No synchronization with background data loading operations - 300ms+ dialog dismissal delay on every test Changes: - Add suppressBatteryDialog option to UITestFixture to prevent battery optimization dialog via SharedPreference - Enable waitForAsyncTasks=true for tests with background data loading, using IdlingResource for proper Espresso synchronization - Skip dialog dismissal entirely when dialogs are pre-suppressed - Reduce default Ultron timeout from 15s to 5s (IdlingResource handles async waits, timeout is just a safety net) Expected improvement: 15-60s per test → 2-5s per test
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip
Note
Phase 1 Room adoption for monitor storage with robust migration and CI support.
MonitorAlertEntity,MonitorAlertDao,MonitorDatabase(withCrSqliteRoomFactory) andRoomMonitorStorage;MonitorStoragenow delegates to RoommanualAlertsV1with NOT NULL PKs and preservesmanualAlertsV1IdxV1; validated byMonitorStorageMigrationTest(open/read/write/update,room_master_tablepresent)CrSqliteRoomFactoryinto main app package; wire KSP task deps; add Room + androidx.sqlite dependencies in appXmlRunListenerto write to internal storage or a-e reportFilepath; adjust scripts (matrix_run_android_tests.sh,generate_android_coverage.sh) and workflow globs to pull per-shard XML and coverageUITestFixturecan grant permissions/suppress battery dialog; test classes updated accordinglyWritten by Cursor Bugbot for commit e7399d2. This will update automatically on new commits. Configure here.