refactor: room integration POC #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williscool
commented
Dec 26, 2025
...d/app/src/androidTest/java/com/github/quarck/calnotify/database/poc/CrSqliteSupportHelper.kt
Outdated
Show resolved
Hide resolved
Code Coverage Report
|
📊 Code Coverage Summary
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
...d/app/src/androidTest/java/com/github/quarck/calnotify/database/poc/CrSqliteSupportHelper.kt
Outdated
Show resolved
Hide resolved
...d/app/src/androidTest/java/com/github/quarck/calnotify/database/poc/CrSqliteSupportHelper.kt
Outdated
Show resolved
Hide resolved
williscool
commented
Dec 29, 2025
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
3 similar comments
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
2 similar comments
📊 Code Coverage Summary
|
📊 Code Coverage Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Validates Room compatibility with cr-sqlite and wires up build/test plumbing needed to load the native extension reliably.
CrSqliteRoomFactoryandCrSqliteFinalizeWrapper(uses Requery SupportSQLiteOpenHelper) plusRoomPocDatabase/Entity/Daoand Android tests covering CRUD, extension loading, finalize-on-close, bulk ops, and parity checksandroidx.sqlite:2.6.2, enablepackagingOptions.jniLibs { useLegacyPackaging = true },pickFirst '**/*.so', and add KSP classpath in rootandroid:extractNativeLibs="true"inAndroidManifest.xml; updates customSQLiteOpenHelperto loadcrsqlite_requeryextensioncrsqlite_requery.so(pinned Rust nightly/NDK) and improve coverage export with sharding supportandroid/.kotlin/Written by Cursor Bugbot for commit 4338c7d. This will update automatically on new commits. Configure here.