This repository was archived by the owner on Oct 14, 2018. It is now read-only.
included exceptionClasses attribute to circute-breaker#7
Open
jamesanto wants to merge 7 commits intowilliewheeler:masterfrom
Open
included exceptionClasses attribute to circute-breaker#7jamesanto wants to merge 7 commits intowilliewheeler:masterfrom
jamesanto wants to merge 7 commits intowilliewheeler:masterfrom
Conversation
Conflicts: src/main/resources/org/zkybase/kite/config/xml/kite-1.0-SNAPSHOT.xsd
There was a problem hiding this comment.
Btw, it is generally not recommended to keep non snapshot version in SCM. The person who will clone the repo and could permanently override the already released version.
Author
There was a problem hiding this comment.
My bad, sorry about that. Please go ahead changing it to a snapshot version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hei Willie,
Glad I found your project. As I tried to use this lib in my project, I found that it was missing a simple configuration. I just modified the xsd and CircuitBreakerTemplate so now it adds the ability to configure list of exceptionClasses in xml file itself. Please merge it if it makes sense...
Thank you.