autompc.control.nmpc: fix broken and unused include#11
Open
mikebentley15 wants to merge 1 commit intowilliamedwards:mainfrom
Open
autompc.control.nmpc: fix broken and unused include#11mikebentley15 wants to merge 1 commit intowilliamedwards:mainfrom
mikebentley15 wants to merge 1 commit intowilliamedwards:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Sphinx documentation generation issues many warnings. One of them appears to be missing optional dependencies even though I installed all dependencies and optional dependencies into a Conda environment:
Investigating further, the
DirectTranscriptionControllerFactoryclass is included fromautompc/control/__init__.pylike soIt turns out this
try..exceptblock was hiding a bug because the include that failed to import wasThe
Iterableclass is incollections.abc, notcollections. Further, thisIterableclass is not used in the file at all.Proposed solution
Remove the inclusion of
Iterableinautompc/control/nmpc.py