Update Feature: Changed modularity to be during build time. #221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmc123
force-pushed
the
feature/build-modularity
branch
from
1377489 to
343e4ec
Compare
Collaborator
Author
|
It should be ready for merge now, you could probably still change "Makefile" now with the changes made to switching between implementations but I haven't done it right now! |
Collaborator
I will take a look! |
GillisC
previously approved these changes
May 7, 2025
Collaborator
GillisC
left a comment
GillisC
left a comment
There was a problem hiding this comment.
Works well for me, saw a decrease 56,000kb --> 48,000kb in just the size of the test executable. One thing that is needed is to add documentation (remove the old stuff) about how the modularity works in the README, so someone new to the project understands how to compile each target e.t.c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed so that switching between implementation is done during build time with the CMake option -DBUILD=...
It is used like this example:
Example:
src/
--/cuda/
one.cpp
--/default/
one.cpp
two.cpp
include/
one.hpp
two.hpp
Cmake -DBUILD=cuda ..
would use:
src/cuda/one.cpp
src/default/two.cpp
include/one.hpp
include/two.hpp
To follow the same pattern you also add CMake configuration this way by including a CMakeLists.txt with your needed configuration under the implementations like cuda/CmakeLists.txt
Also added a cuda gemm, this was mostly done during my testing but there is no reason to not include it really.
Issue
Closes #220