Allow creation of new websocket, even if one exists already (forceNew)#21
Open
go-ive wants to merge 6 commits intowilk:masterfrom
go-ive:master
Open
Allow creation of new websocket, even if one exists already (forceNew)#21go-ive wants to merge 6 commits intowilk:masterfrom go-ive:master
go-ive wants to merge 6 commits intowilk:masterfrom
go-ive:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, Me and a few colleagues of mine are working on a project and are using ngWebsocket in it. We had some trouble to refresh a websocket connection and had the case where we had to re-initialize it completely. Since this wasn't yet possible with ngWebsocket, I added this extra flag (forceNew) to return a new connection on demand, no matter if it was created before. It would be awesome, if you could include my change into the newest version. Regards, Ivan.