Allow "self" frame ancestors to fix customizer#20
Merged
allysonsouza merged 1 commit intomainfrom Jan 9, 2025
Merged
Conversation
The WordPress customizer uses an iframe to embed the site, so we need to permit "self" ancestors on the CSP frame directive. WIKI-1052 Signed-off-by: K Adam White <kadamwhite@users.noreply.github.com>
goldenapples
approved these changes
Jan 6, 2025
Collaborator
Author
|
This has been merged to develop for testing, but should also be good to roll directly to main. Deferring until sprint starts unless Allyson finds its necessary to fix WIKI-1050 |
Collaborator
|
I've tested it locally and it does fix the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WordPress customizer uses an iframe to embed the site, so we need to permit "self" ancestors on the CSP frame directive.
WIKI-1052