-
Notifications
You must be signed in to change notification settings - Fork 30
build: Add phan #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
build: Add phan #465
Conversation
|
Please Rebase and merge this PR into the main branch. |
|
You shouldn't merge this until Phan 6.x which is PHP 8.5 compatible, as you have found. |
| print "Reading langdb.yaml...\n"; | ||
| $yamlLangdb = file_get_contents( DATA_DIRECTORY . '/langdb.yaml' ); | ||
| // spyc_load is from mustangostang/spyc. Only needed during development. | ||
| // @phan-suppress-next-line PhanUndeclaredFunction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be a sign that this script doesn't actually want to be in src/
jdforrester
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I said, please back out the Phan changes until 8.5 is working, rather than regress the state.
I'd prefer to include Phan now and remove PHP 8.5 compatibility to keep it inline with WMF usage. We can update to Phan 6.x and PHP 8.5 when upstream work is done. |
675e7d3 to
e50c656
Compare
Wikimedia CI will enforce PHP 8.5 soon. So this repo now won't be able to be a library in vendor until Phan 6 is released. |
|
I submitted: #473 for the non-phan related changes. |
Thanks! I've now rebased this down to just the phan installation. |
|
This is fine, but shouldn't be landed until the upstream fixes are released (and the 8.5 removal is dropped). We aren't allowing new non-PHP 8.5 libraries into mediawiki/vendor.git. |
This PR adds the following commits:
Minimum PHP version has been updated to v8.1
Had to drop support for PHP 8.5 to fix CI errors:
See: https://github.com/wikimedia/language-data/actions/runs/19819690893/job/56779101738?pr=465
Bug: https://phabricator.wikimedia.org/T410000