Skip to content

Conversation

@razor85
Copy link

@razor85 razor85 commented Mar 11, 2023

Allows adding custom boot entries by creating a file called bootOptions.cfg in the :sd/wiiu/environments/tiramisu/ folder.
An example of such file is:

Nintendont,0x57574e44,vWii
WiiUChat,0xA,wiiu

The above configuration will display two new entries in the boot menu:

  • "Nintendont" (titleId 0x57574e44, vWii Channel)
  • "WiiUChat" (titleId 0xA, WiiU Channel)

I didn't do anything to support scrolling entries but I think that might be too much.

@Maschell
Copy link
Contributor

Thanks for your Pull Request! I'll take a deeper look at this later, but here a few things I noticed:

  • bootWiiuTitle (getVWiiTitleId... and friends) should not take a string, but the uint64_t as a parameter. The parsing should only be tied to the config loading.
  • Using streams will bloat the binary without gaining that much readablity. Please use strtol instead!
  • Do all vWii titles always start with 0x00010001. I actually have no idea. I would just always provide the full title id. With the full title id you can also get rid of the "vWii" vs "wiiu" part, looking at the titleId is enough

@razor85
Copy link
Author

razor85 commented Mar 11, 2023

Thanks for your comments. The full title id is indeed a good idea and cleans up a bunch of code.
About the streams, I didn't know they would really make a big difference but seeing the binary size now, it almost doubled.
I will also clang-format clean it.

@razor85
Copy link
Author

razor85 commented Mar 14, 2023

Gave another thought about it (sorry busy days) and was wondering if I indeed could get rid of the wiiu/vwii setting. It appears to me vWii titles are loaded through mocha and then CMPTLaunchTitle whilst wiiu titles are loaded via _SYSLaunchTitleWithStdArgsInNoSplash. Is this correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants