docs: change the theme#238
Conversation
|
I like the theme and your plans! |
|
requires #240 to move forward |
368ca6d to
e241012
Compare
0017486 to
f4937c0
Compare
|
@mariobuikhuizen I'll stop this PR here to avoid a too big scope. what is cover is the following:
work that I will do in the following-up PR: reorder pages to make better use of the theme sidebars. In case you think this should not be put in production yet (to which I agree) you should publish a stable version of the docs in RDT and link it in the readme. I think you need to make a GitHub release for that, else you can manually trigger the rebuild of stable. Let me know what you prefer. |
|
Thank you for not increasing the scope further! Can you please remove the changes not related to changing the theme? |
|
I scanned the modifications again and I see 2 potential candidates:
Which should I remove ? |
|
To be clear, those changes are good to do, but not in the PR called "change the theme". |
|
then the answer is "both of them" 😄 Understood, I'll create other PR for them |
|
Thank you 😄 |
|
let's wait for the test completion but normally I'm good to go |
|
One of the advantages of keeping changes as concise as possible is less chance of conflicts. #272 also changes code formatting: 32273a0#diff-85933aa74a2d66c3e4dcdf7a9ad8397f5a7971080d34ef1108296a7c6b69e7e3R25 , which leads to a conflict here. Also, I see now that that PR removes |
|
conflict resolved. |
|
If I check the build on: https://ipyvuetify--238.org.readthedocs.build/en/238/ I don't see the new theme applied |
mariobuikhuizen
left a comment
There was a problem hiding this comment.
Much cleaner diff now! 😄
|
Thanks! |
Turns out older branches don't build anymore, so we're forced to put it in production. I trust it runs well. |
|
ok I'll try to be as fast as possible to make the follow-up PR to have a more readable documentation ASAP |
|
What less readable now? |
|
Come to think of it I can also point the stable branch to just before the theme change commit. That will give more time to make your changes. |
|
Production docs are back to the old theme. |
@mariobuikhuizen, I would like to work on the documentation and update the template that is used. my objective are the following :
This PR is just a demo using pydata-sphinx-theme, is there a chance to see this PR merged if I continue working on it ?
Related to #268