fix: script with curly brace before component would error#99
Merged
maartenbreddels merged 3 commits intomasterfrom Sep 10, 2025
Merged
fix: script with curly brace before component would error#99maartenbreddels merged 3 commits intomasterfrom
maartenbreddels merged 3 commits intomasterfrom
Conversation
maartenbreddels
force-pushed
the
fix_script_with_curly_before_component
branch
3 times, most recently
from
a93680d to
76e4b01
Compare
maartenbreddels
force-pushed
the
fix_script_with_curly_before_component
branch
2 times, most recently
from
d946393 to
cfc6553
Compare
mariobuikhuizen
approved these changes
Sep 10, 2025
because we 'eval' everything from the first curly brace, but that curly brace in a comment. This is common when you want to add type checking using jsdoc, which would look like this: ``` /** * @typedef {import('@/types/foo').Bar} Bar */ We now evaluate more like a CommonJS module, but fall back to the old behaviour. ```
maartenbreddels
force-pushed
the
fix_script_with_curly_before_component
branch
from
cfc6553 to
93820e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
because we 'eval' everything from the first curly brace, but that curly brace in a comment. This is common when you want to add type checking using jsdoc, which would look like this:
We now evaluate more like a CommonJS module, but fall back to the old
behaviour.