Conversation
maartenbreddels
left a comment
There was a problem hiding this comment.
Nice!
Any idea why this extra click is needed, is that an issue that needs solving?
I guess we could also do a UI test for this PR right? For instance a context menu?
| self._event_handlers_map[event_and_modifiers] = CallbackDispatcher() | ||
|
|
||
| self._event_handlers_map[event_and_modifiers].register_callback( | ||
| callback, remove=remove |
There was a problem hiding this comment.
Slightly unrelated but I think this code (81-95) is very hard to read, or does not work. The register_callback call with remove=True is a no-op or maybe it gives an exception?
Would make me feel more comfortable is we had a test for this.
It's just how Vuetify menu works. Click out-side first closes the menu, the next click opens the menu on the new position. This is fine for menu, but as a context menu this is a bit unexpected. |
|
Right, that means for solara, we probably need a custom template anyway. |
Making the following possible:
One thing I noticed though, is that we need an extra right-click to show the menu on a different spot. So it might not be useful for the original envisioned use-case.