fix: avoid using a global force_load widget#56
Open
maartenbreddels wants to merge 2 commits intowidgetti:masterfrom
Open
fix: avoid using a global force_load widget#56maartenbreddels wants to merge 2 commits intowidgetti:masterfrom
maartenbreddels wants to merge 2 commits intowidgetti:masterfrom
Conversation
maartenbreddels
force-pushed
the
fix_non_global_widgets
branch
2 times, most recently
from
0d6ada4 to
5289093
Compare
maartenbreddels
force-pushed
the
fix_non_global_widgets
branch
from
5289093 to
5eb7afd
Compare
maartenbreddels
force-pushed
the
fix_non_global_widgets
branch
from
5eb7afd to
ba43eea
Compare
mariobuikhuizen
force-pushed
the
master
branch
from
a6d7d06 to
48562f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead, we create a singleton on the fly when needed.
This also allows in multi-user environments to have 1 singleton per user.