Skip to content

Complete work of showing green if checks fail on experimental rubies. #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etagwerker merged 1 commit into from
Oct 15, 2025
Merged

Complete work of showing green if checks fail on experimental rubies. #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,6 @@ jobs:
needs: pre_job # skip duplicates
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
Expand All @@ -79,12 +78,12 @@ jobs:
cache-version: 1
- name: Run Rubocop
run: bundle exec rubocop
continue-on-error: ${{ matrix.experimental }}

Reek:
needs: pre_job # skip duplicates
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
Expand All @@ -109,12 +108,12 @@ jobs:
cache-version: 1
- name: Run Reek
run: bundle exec rake reek
continue-on-error: ${{ matrix.experimental }}

Minitest:
needs: pre_job # skip duplicates
if: ${{ needs.pre_job.outputs.should_skip != 'true' }}
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.experimental }}
strategy:
fail-fast: false
matrix:
Expand All @@ -129,7 +128,6 @@ jobs:
experimental: true
- ruby-version: 'jruby-9.4'
experimental: true

steps:
- uses: actions/checkout@v4
- name: Set up Ruby ${{ matrix.ruby-version }}
Expand All @@ -140,6 +138,7 @@ jobs:
cache-version: 1
- name: Run Unit tests
run: bundle exec rake test
continue-on-error: ${{ matrix.experimental }}

MarkdownLint:
needs: pre_job # skip duplicates
Expand Down