Allow run RubyCritic outside of project #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuanVqz
force-pushed
the
feature/run-rubycritic-from-outside
branch
4 times, most recently
from
6916e81 to
9ccf3d6
Compare
Contributor
Author
|
@etagwerker It would be nice if you could review and merge these changes. CI was fixed in this PR #526 if you merge that PR, I can rebase, and all should be good. Thanks! |
Collaborator
|
Hey @JuanVqz could you rebase this PR on top of the latest main please? |
JuanVqz
force-pushed
the
feature/run-rubycritic-from-outside
branch
from
9ccf3d6 to
1216374
Compare
JuanVqz
commented
Jul 28, 2025
| # :reek:DuplicateMethodCall | ||
| # :reek:NilCheck | ||
| def self.supported? | ||
| git('branch 2>&1') && $CHILD_STATUS.success? |
Contributor
Author
There was a problem hiding this comment.
JFI: This was the main reason we could not run the RubyCritic command outside of the project; the Git class checks for the existence of git in the current path (pwd), and if it exists, it returns a supported? value as true.
JuanVqz
force-pushed
the
feature/run-rubycritic-from-outside
branch
from
3e53edf to
f4967b1
Compare
Contributor
Author
|
Hey @fbuys, This is ready for review :) |
rishijain
approved these changes
Jul 30, 2025
fbuys
approved these changes
Jul 30, 2025
Collaborator
fbuys
left a comment
fbuys
left a comment
There was a problem hiding this comment.
Thank you! I tested it locally on different projects and it works as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously, obtaining the
churnvalue required running therubycriticcommand from within the project directory, as it depended on being in a.gitcontext. This limitation prevented running the command from outside the project.This PR addresses the issue by inspecting
RubyCritic::Config.pathsto locate the project root—identified by the presence of a.gitdirectory. Thechurncontext is then established from this root directory, allowing therubycriticcommand to be executed from any location, not just within the project directory.This change improves flexibility and usability for users running
rubycritic.Check list:
I didn't do it but you can do it when merging into main, is that fine?