Conversation
annevk
force-pushed
the
annevk/getter-setter
branch
from
17ddc93 to
3fe424e
Compare
domenic
approved these changes
Jun 1, 2020
Member
domenic
left a comment
domenic
left a comment
There was a problem hiding this comment.
LGTM, great improvements. I noticed a few other things you could touchup and left them as comments, but they are totally optional since you're already in yak-shaving territory.
| be at the start of <span>this</span>.</p></li> | ||
|
|
||
| <li><p>Run the <span>focusing steps</span> for <span>this</span>'s <span>document | ||
| element</span>, if non-null.</p></li> |
Member
There was a problem hiding this comment.
Nit: "If this's document element is non-null, then run the focusing steps for this's document element" would be much clearer IMO.
| <li><p>Set <span>this</span>'s <span>design mode enabled</span> to true.</p></li> | ||
|
|
||
| <li><p>Reset <span>this</span>'s <span>active range</span>'s start and end boundary points to | ||
| be at the start of <span>this</span>.</p></li> |
Member
There was a problem hiding this comment.
Optional: this could have more cross-links and be more rigorous, e.g. https://dom.spec.whatwg.org/#concept-range-start and setting the offset to 0 instead of "the start of this".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Endless yak shaving is endless. See #5560 for context.
/acknowledgements.html ( diff )
/dom.html ( diff )
/index.html ( diff )
/interaction.html ( diff )