Add external <script type=speculationrules>#11697
Add external <script type=speculationrules>#11697vickiez wants to merge 12 commits intowhatwg:mainfrom
Conversation
0f1c473 to
59d995a
Compare
noamr
left a comment
There was a problem hiding this comment.
Thanks for working on this! See initial comments.
source
Outdated
There was a problem hiding this comment.
This destination needs to be defined in the fetch spec.
There was a problem hiding this comment.
There's a change in progress here: whatwg/fetch#1841. Happy to help with that one, is there a proper order for merging the changes across specs?
There was a problem hiding this comment.
Merging them as close together as possible provided they are both unblocked and generally agreed upon is fine. But regarding this PR: is there cross-browser interest in this feature overall? The PR template is pretty scant.
There was a problem hiding this comment.
Filled in the PR template with implementation bugs and just created position requests here:
Support external <script type=speculationrules> · Issue #1343 · mozilla/standards-positions
Support external <script type=speculationrules> · Issue #604 · WebKit/standards-positions
There was a problem hiding this comment.
Also for some context - this change was meant to be included in the base speculation rules spec change to achieve completeness. I was planning on merging it into Domenic's branch, but his change was merged into HTML first. See the comment here - #11123 (comment)
|
See #11697 (comment), but just so the sentiment doesn't get lost in that thread, let me ask here: is there cross-browser support for this? I'm asking because the PR template is a bit bare and I'm not sure where other folks stand on this PR, although I'm happy to review it. |
Add external <script type="speculationrules">
Allows a speculation rules script element to have a src pointing to a
file of speculation rules, enabling developers to easily reuse a set of
speculation rules across HTML documents.
WICG/nav-speculation#348
Spec changes:
Add a row for external speculation rules in the attributes table of
4.12.1 The script element
During prepare the script element, handle the case where
srccontent attribute is present and
typeis"speculationrules"Define a "fetch speculation rules" algorithm to be used by both the
external script and 7.6.3 The
Speculation-Rulesheader sections.(See WHATWG Working Mode: Changes for more details.)
/scripting.html ( diff )
/speculative-loading.html ( diff )
/webappapis.html ( diff )