Add webtransport-hashes to request, wired down to create a connection#1896
Merged
annevk merged 6 commits intowhatwg:mainfrom Jan 28, 2026
Merged
Add webtransport-hashes to request, wired down to create a connection#1896annevk merged 6 commits intowhatwg:mainfrom
annevk merged 6 commits intowhatwg:mainfrom
Conversation
Contributor
Author
|
Build appears to have stalled on infra unrelated to PR? ("Run pip install bikeshed && bikeshed update") cc @annevk |
This was referenced Dec 15, 2025
b296f9e to
6614713
Compare
annevk
reviewed
Dec 18, 2025
Member
annevk
left a comment
There was a problem hiding this comment.
I rebased (which should address the CI issue you encountered) and pushed a commit addressing a number of nits. This looks good to me, but I have a couple of questions that might result in a couple more tweaks.
Note that I had to force push to your branch so you'll have to reset if you want to commit and push again.
Contributor
Author
|
@annevk Thanks for your help! If we merge this one first, then w3c/webappsec-csp#791 and w3c/webtransport#711 can follow. |
Contributor
Author
|
@annevk to clarify this should have all your feedback and be ready to merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an associated webtransport-hashes (a webtransport-hash list) to request, and wire it down to create a connection. For use by WebTransport and CSP w3c/webappsec-csp#791.
Fixes #1880.
Preview | Diff