Verify download using sha1 checksum, if possible#23
Open
stisti wants to merge 1 commit intowfarr:masterfrom
Open
Verify download using sha1 checksum, if possible#23stisti wants to merge 1 commit intowfarr:masterfrom
stisti wants to merge 1 commit intowfarr:masterfrom
Conversation
a101579 to
68c391f
Compare
Collaborator
|
Hi Thanks for the contribution, really appreciated. Would you try to rebase your branch to the latest master? Also we added Thanks! |
Author
|
Sure, will do. 2015-08-10 22:52 GMT+03:00 Daniel Aristizabal notifications@github.com:
|
Download also SHASUMS256.txt file and check the downloaded tar package is good. Apparently the older node versions do not have a checksum file, so do not fail, just warn, if the checksum file cannot be downloaded.
68c391f to
30491a9
Compare
Author
|
Here you go. I switched to using sha256 because that's what iojs seems to use. |
Collaborator
|
@stisti Aweomse. Thank you so much for taking the time. I'll review and merge ASAP. Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Download also SHASUMS.txt file and check the downloaded tar package is good.
Apparently the older node versions do not have a SHASUMS.txt file, so do not
fail, just warn, if the SHASUMS.txt cannot be downloaded.