Update/speed calculation update #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that the carousel runs at a constant speed, regardless of the number of items in the carousel. The speed is calculated based on the total width of the items in the carousel and the desired speed in pixels per second. Added a padding parameter, which allows the user to specify the amount of space to be added to the animation in order to ensure that the items are not cut off at the edges of the carousel.
marlonmarcello
approved these changes
Mar 31, 2025
andrewrubin
requested changes
Mar 31, 2025
Member
andrewrubin
left a comment
andrewrubin
left a comment
There was a problem hiding this comment.
Looks good @liamegan! Can we please update the docs accordingly before merging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The carousel was having issues maintaining a consistent speed with different numbers of items.
Solution
Updating the calculation for the carousel speed.
This ensures that the carousel runs at a constant speed, regardless of the number of items in the carousel. The speed is calculated based on the total width of the items in the carousel and the desired speed in pixels per second.
Added a padding parameter, which allows the user to specify the amount of space to be added to the animation in order to ensure that the items are not cut off at the edges of the carousel.