Fix panic profiling server #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While here, move it before the main web server since this should be fairly fast to shut down. Also the timeout is shorter. Signed-off-by: Ville Valkonen <weezel@users.noreply.github.com>
Trying to access method in nil pointer trips the flow. Who would have guessed? Signed-off-by: Ville Valkonen <weezel@users.noreply.github.com>
Same as in the previous commit: uninitialized sync.Once. Also the connection closing order was wrong, socket must the fast to be closed. That caused issue with graceful shutdown. Signed-off-by: Ville Valkonen <weezel@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes panic in OTEL shutdown.