emoji.lua: Add rofl=😂 and other improvements #585
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shut up linter (explicitly use _G or local) Moved emoji table to the end and its divided by line str2emoji(): pattern uses %w instead of manual set str2emoji(): gsub points to table instead of function (faster) use string.find in conditionals not string.match Use function alias for functions that all do the same thing aesthetic changes (for line limit)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linter: functions explicitly go to _G or are local
Moved emoji table of the end and its divided by line (diffs were ridiculously big)
str2emoji(): pattern uses %w instead of manual set, gsub points to table instead of function (faster)
use string.find in conditionals not string.match
Use a single function alias for functions that all do the same thing
aesthetic changes (for line limit)
Script info
Description
Checklist (script update)
script_name.py X.Y: …Author is xt which is not in the channel, and I doubt the email works (website doesn't) I think @torhve is the author?