Skip to content

Fix for UTF-8 problems with the ascii printer. #661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlbertShown merged 3 commits into from
Oct 23, 2025
Merged

Fix for UTF-8 problems with the ascii printer. #661

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a067d2
Fix for UTF-8 problems with the ascii printer.
hdijkema Oct 22, 2025
adf6ff8
Updating code to follow current coding style
AlbertShown Oct 23, 2025
1456940
Fix typo (_webui_print_ascii)
AlbertShown Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/webui.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8847,11 +8847,19 @@ static void _webui_print_hex(const char* data, size_t len) {
}
}
static void _webui_print_ascii(const char* data, size_t len) {
// This function is used to print the protocol binary packets. the packet
// may have ASCII and `0x00` inside text, as well as other non-ascii bytes
for (size_t i = 0; i < len; i++) {
if ((unsigned char)* data == 0x00)
_webui_log_debug("%c", 0xCF);
else
_webui_log_debug("%c", (unsigned char)* data);
register unsigned char c = (unsigned char)* data;
if (c == 0x00) {
_webui_log_debug("%c", 0xCF); // Print `¤` | TODO: Maybe we can simply print a blank space?
} else {
if (c < 32 || c > 126) {
_webui_log_debug("[0x%02X]", c);
} else {
_webui_log_debug("%c", c);
}
}
data++;
}
}
Expand Down
Loading