Add more dump location quirks for vtcapture#133
Open
sundermann wants to merge 2 commits intowebosbrew:mainfrom
Open
Add more dump location quirks for vtcapture#133sundermann wants to merge 2 commits intowebosbrew:mainfrom
sundermann wants to merge 2 commits intowebosbrew:mainfrom
Conversation
959b2a3 to
878cb1f
Compare
There was a problem hiding this comment.
PR Overview
This PR expands the available dump locations in the vtcapture API by adding several new quirks and updating the README table accordingly.
- Updated the table header formatting.
- Modified the description for QUIRK_ALTERNATIVE_DUMP_LOCATION.
- Added four new quirks with corresponding flags for alternative dump locations.
Reviewed Changes
| File | Description |
|---|---|
| README.md | Updated table formatting and added new quirks rows |
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
README.md:52
- [nitpick] The table divider row has been modified. Please verify that the alignment and spacing render correctly in various markdown viewers.
|-------------------|-----------------------------------|---------------------------------------------------------------------------------|-------|
Collaborator
|
@sundermann fyi, I recently found this information in the header files of my TVs kernel source. From this I would assume we cannot be 100% sure about the value to name mapping on all TVs. |
Contributor
Author
|
I don't see the issue here. It seems to be just the same thing except for the last two locations which are missing on your device. the naming also doesn't really matter. |
Collaborator
|
Not an issue, just a note. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more dump locations available in the
vtcaptureAPI.