Use cargo_metadata to get manifest data
#82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses the `cargo_metadata` crate to derive information about
the crate, as opposed to only parsing `Cargo.toml`.
In particular, this helps when fields in the manifest are inherited from
the workspace, for example if `version = { workspace = true }`.
One thing `cargo_metadata` does not provide, is badges, so these are
still parsed from `Cargo.toml`.
The error messages also changed as a result of propagating the errors
from `cargo_metadata`, and thus some of the tests had to be altered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit uses the
cargo_metadatacrate to derive information about the crate, as opposed to only parsingCargo.toml.In particular, this helps when fields in the manifest are inherited from the workspace, for example if
version = { workspace = true }.One thing
cargo_metadatadoes not provide, is badges, so these are still parsed fromCargo.toml.The error messages also changed as a result of propagating the errors from
cargo_metadata, and thus some of the tests had to be altered.